Don't mark non-varied constant params #1148

ovdiiuv · 2024-11-21T15:52:58Z

No description provided.

github-actions

clang-tidy made some suggestions

include/clad/Differentiator/DiffPlanner.h

lib/Differentiator/ActivityAnalyzer.cpp

codecov · 2024-11-21T18:02:30Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.58%. Comparing base (90061ef) to head (7bf55f3).
Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1148      +/-   ##
==========================================
+ Coverage   94.56%   94.58%   +0.01%     
==========================================
  Files          51       51              
  Lines        8947     8972      +25     
==========================================
+ Hits         8461     8486      +25     
  Misses        486      486

Files with missing lines	Coverage Δ
include/clad/Differentiator/DerivativeBuilder.h	`100.00% <ø> (ø)`
include/clad/Differentiator/DiffPlanner.h	`77.41% <100.00%> (+9.23%)`	⬆️
lib/Differentiator/ActivityAnalyzer.cpp	`100.00% <100.00%> (ø)`
lib/Differentiator/DiffPlanner.cpp	`98.64% <100.00%> (-0.02%)`	⬇️
lib/Differentiator/ReverseModeVisitor.cpp	`95.59% <100.00%> (ø)`

Files with missing lines	Coverage Δ
include/clad/Differentiator/DerivativeBuilder.h	`100.00% <ø> (ø)`
include/clad/Differentiator/DiffPlanner.h	`77.41% <100.00%> (+9.23%)`	⬆️
lib/Differentiator/ActivityAnalyzer.cpp	`100.00% <100.00%> (ø)`
lib/Differentiator/DiffPlanner.cpp	`98.64% <100.00%> (-0.02%)`	⬇️
lib/Differentiator/ReverseModeVisitor.cpp	`95.59% <100.00%> (ø)`

github-actions

clang-tidy made some suggestions

lib/Differentiator/ActivityAnalyzer.cpp

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 19. Check the log or trigger a new build to see more.

github-actions · 2024-11-25T00:34:09Z

include/clad/Differentiator/DiffPlanner.h

    bool HasAnalysisRun = false;
  } m_ActivityRunInfo;

 public:
+  static std::set<const clang::VarDecl*> AllVariedDecls;


warning: variable 'AllVariedDecls' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]

static std::set<const clang::VarDecl*> AllVariedDecls; ^

github-actions · 2024-11-25T00:34:09Z

lib/Differentiator/ActivityAnalyzer.cpp

+    QualType innermost = VDTy;
+    while (innermost->isPointerType())
+      innermost = innermost->getPointeeType();
+    if (VDTy->isPointerType() && !innermost.isConstQualified()) {


warning: repeated branch in conditional chain [bugprone-branch-clone]

if (VDTy->isPointerType() && !innermost.isConstQualified()) { ^

Additional context

lib/Differentiator/ActivityAnalyzer.cpp:165: end of the original

} else if (VDTy->isArrayType()) { ^

lib/Differentiator/ActivityAnalyzer.cpp:165: clone 1 starts here

} else if (VDTy->isArrayType()) { ^

github-actions · 2024-11-25T00:34:09Z

lib/Differentiator/DiffPlanner.cpp

-          } else if (isa<FunctionDecl>(DRE->getDecl()))
-            m_FnDRE = DRE;
-          return false;
+std::set<const clang::VarDecl*> DiffRequest::AllVariedDecls;


warning: variable 'AllVariedDecls' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]

std::set<const clang::VarDecl*> DiffRequest::AllVariedDecls; ^

github-actions · 2024-11-25T00:34:09Z

lib/Differentiator/DiffPlanner.cpp

-          return false;
+std::set<const clang::VarDecl*> DiffRequest::AllVariedDecls;
+
+static SourceLocation noLoc;


warning: variable 'noLoc' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]

static SourceLocation noLoc; ^

github-actions · 2024-11-25T00:34:09Z

lib/Differentiator/DiffPlanner.cpp

+/// \param SemaRef Reference to Sema
+DeclRefExpr* getArgFunction(CallExpr* call, Sema& SemaRef) {
+  struct Finder : RecursiveASTVisitor<Finder> {
+    Sema& m_SemaRef;


warning: member 'm_SemaRef' of type 'Sema &' is a reference [cppcoreguidelines-avoid-const-or-ref-data-members]

Sema& m_SemaRef; ^

github-actions · 2024-11-25T00:34:09Z

lib/Differentiator/DiffPlanner.cpp

+        : m_SemaRef(SemaRef), m_BeginLoc(beginLoc) {}
+
+    // Required for visiting lambda declarations.
+    bool shouldVisitImplicitCode() const { return true; }


warning: function 'shouldVisitImplicitCode' should be marked [[nodiscard]] [modernize-use-nodiscard]

Suggested change

bool shouldVisitImplicitCode() const { return true; }

[[nodiscard]] bool shouldVisitImplicitCode() const { return true; }

github-actions · 2024-11-25T00:34:09Z

lib/Differentiator/DiffPlanner.cpp

+        : m_SemaRef(SemaRef), m_BeginLoc(beginLoc) {}
+
+    // Required for visiting lambda declarations.
+    bool shouldVisitImplicitCode() const { return true; }


warning: method 'shouldVisitImplicitCode' can be made static [readability-convert-member-functions-to-static]

Suggested change

bool shouldVisitImplicitCode() const { return true; }

static bool shouldVisitImplicitCode() { return true; }

lib/Differentiator/DiffPlanner.cpp

github-actions

clang-tidy made some suggestions

github-actions · 2024-11-25T17:27:08Z

lib/Differentiator/DiffPlanner.cpp

+
+      // Emit error diagnostics
+      if (R.empty()) {
+        const char diagFmt[] = "'%0' has no defined operator()";


warning: do not declare C-style arrays, use std::array<> instead [cppcoreguidelines-avoid-c-arrays]

const char diagFmt[] = "'%0' has no defined operator()"; ^

github-actions · 2024-11-25T17:27:08Z

lib/Differentiator/DiffPlanner.cpp

+        m_SemaRef.Diag(m_BeginLoc, diagId) << RD->getName();
+        return false;
+      } else if (!R.isSingleResult()) {
+        const char diagFmt[] =


warning: do not declare C-style arrays, use std::array<> instead [cppcoreguidelines-avoid-c-arrays]

const char diagFmt[] = ^

github-actions · 2024-11-25T17:27:08Z

lib/Differentiator/DiffPlanner.cpp

+        // Emit diagnostics for candidate functions
+        for (auto oper = R.begin(), operEnd = R.end(); oper != operEnd;
+             ++oper) {
+          auto candidateFn = cast<CXXMethodDecl>(oper.getDecl());


warning: 'auto candidateFn' can be declared as 'auto *candidateFn' [llvm-qualified-auto]

auto candidateFn = cast<CXXMethodDecl>(oper.getDecl()); ^

this fix will not be applied because it overlaps with another fix

github-actions · 2024-11-25T17:27:08Z

lib/Differentiator/DiffPlanner.cpp

+      } else if (R.isSingleResult() == 1 &&
+                 cast<CXXMethodDecl>(R.getFoundDecl())->getAccess() !=
+                     AccessSpecifier::AS_public) {
+        const char diagFmt[] =


warning: do not declare C-style arrays, use std::array<> instead [cppcoreguidelines-avoid-c-arrays]

const char diagFmt[] = ^

lib/Differentiator/DiffPlanner.cpp

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 28. Check the log or trigger a new build to see more.

github-actions · 2024-12-12T16:03:45Z

include/clad/Differentiator/DiffPlanner.h

@@ -3,12 +3,12 @@

 #include "clang/AST/RecursiveASTVisitor.h"
 #include "llvm/ADT/SmallSet.h"
+#include <iterator>
+#include <set>


warning: included header iterator is not used directly [misc-include-cleaner]

Suggested change

#include <set>

#include <set>

github-actions · 2024-12-12T16:03:45Z

include/clad/Differentiator/DiffPlanner.h

@@ -34,11 +35,13 @@
  } m_TbrRunInfo;

  mutable struct ActivityRunInfo {
-    std::set<const clang::VarDecl*> ToBeRecorded;
+    std::set<const clang::VarDecl*> VariedDecls;


warning: no header providing "clang::VarDecl" is directly included [misc-include-cleaner]

include/clad/Differentiator/DiffPlanner.h:5:

- #include <iterator> + #include <clang/AST/Decl.h> + #include <iterator>

github-actions · 2024-12-12T16:03:45Z

include/clad/Differentiator/DiffPlanner.h

    bool HasAnalysisRun = false;
  } m_ActivityRunInfo;

 public:
+  const DerivativeBuilder* Builder = nullptr;


warning: member variable 'Builder' has public visibility [cppcoreguidelines-non-private-member-variables-in-classes]

const DerivativeBuilder* Builder = nullptr; ^

github-actions · 2024-12-12T16:03:45Z

include/clad/Differentiator/DiffPlanner.h

@@ -144,6 +148,16 @@

  bool shouldBeRecorded(clang::Expr* E) const;
  bool shouldHaveAdjoint(const clang::VarDecl* VD) const;
+
+  void setVariedDecls(std::set<const clang::VarDecl*> init) {


warning: the parameter 'init' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]

Suggested change

void setVariedDecls(std::set<const clang::VarDecl*> init) {

void setVariedDecls(const std::set<const clang::VarDecl*>& init) {

github-actions · 2024-12-12T16:03:46Z

include/clad/Differentiator/DiffPlanner.h

@@ -144,6 +148,16 @@

  bool shouldBeRecorded(clang::Expr* E) const;
  bool shouldHaveAdjoint(const clang::VarDecl* VD) const;
+
+  void setVariedDecls(std::set<const clang::VarDecl*> init) {
+    for (auto* vd : init)


warning: 'auto *vd' can be declared as 'const auto *vd' [readability-qualified-auto]

Suggested change

for (auto* vd : init)

for (const auto* vd : init)

github-actions · 2024-12-12T16:03:46Z

include/clad/Differentiator/DiffPlanner.h

+  std::set<const clang::VarDecl*> getVariedDecls() const {
+    return this->m_ActivityRunInfo.VariedDecls;
+  }
+  DiffRequest() : Builder(nullptr) {}


warning: member initializer for 'Builder' is redundant [cppcoreguidelines-use-default-member-init]

Suggested change

DiffRequest() : Builder(nullptr) {}

DiffRequest() : {}

github-actions · 2024-12-12T16:03:46Z

lib/Differentiator/ActivityAnalyzer.cpp

    MutableArrayRef<ParmVarDecl*> FDparam = FD->parameters();
    for (std::size_t i = 0, e = CE->getNumArgs(); i != e; ++i) {
      clang::Expr* par = CE->getArg(i);
+
+      QualType parType = FDparam[i]->getType();


warning: no header providing "clang::QualType" is directly included [misc-include-cleaner]

lib/Differentiator/ActivityAnalyzer.cpp:1:

+ #include <clang/AST/Type.h>

github-actions · 2024-12-12T16:03:46Z

lib/Differentiator/ActivityAnalyzer.cpp

+      if (m_Varied)
+        m_VariedDecls.insert(FDparam[i]);
+      else if ((parType->isReferenceType() ||
+                (utils::isArrayOrPointerType(parType) &&


warning: no header providing "clad::utils::isArrayOrPointerType" is directly included [misc-include-cleaner]

lib/Differentiator/ActivityAnalyzer.cpp:1:

+ #include <clad/Differentiator/CladUtils.h>

github-actions · 2024-12-12T16:03:46Z

lib/Differentiator/ActivityAnalyzer.cpp

  return true;
 }

 bool VariedAnalyzer::VisitDeclStmt(DeclStmt* DS) {
  for (Decl* D : DS->decls()) {
+
+    QualType VDTy = cast<VarDecl>(D)->getType();


warning: no header providing "clang::cast" is directly included [misc-include-cleaner]

QualType VDTy = cast<VarDecl>(D)->getType(); ^

github-actions · 2024-12-12T16:03:46Z

lib/Differentiator/DiffPlanner.cpp

-            m_FnDRE = DRE;
-          return false;
+// std::set<const clang::VarDecl*> DiffRequest::AllVariedDecls;
+static SourceLocation noloc;


warning: no header providing "clang::SourceLocation" is directly included [misc-include-cleaner]

lib/Differentiator/DiffPlanner.cpp:20:

+ #include <clang/Basic/SourceLocation.h>

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 20. Check the log or trigger a new build to see more.

github-actions · 2024-12-12T17:14:23Z

lib/Differentiator/DiffPlanner.cpp

-            m_FnDRE = DRE;
-          return false;
+// std::set<const clang::VarDecl*> DiffRequest::AllVariedDecls;
+static SourceLocation noloc;


warning: variable 'noloc' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]

static SourceLocation noloc; ^

github-actions · 2024-12-12T17:14:23Z

lib/Differentiator/DiffPlanner.cpp

+/// \param SemaRef Reference to Sema
+DeclRefExpr* getArgFunction(CallExpr* call, Sema& SemaRef) {
+  struct Finder : RecursiveASTVisitor<Finder> {
+    Sema& m_SemaRef;


warning: member 'm_SemaRef' of type 'Sema &' is a reference [cppcoreguidelines-avoid-const-or-ref-data-members]

Sema& m_SemaRef; ^

github-actions · 2024-12-12T17:14:23Z

lib/Differentiator/DiffPlanner.cpp

+        : m_SemaRef(SemaRef), m_BeginLoc(beginLoc) {}
+
+    // Required for visiting lambda declarations.
+    bool shouldVisitImplicitCode() const { return true; }


warning: function 'shouldVisitImplicitCode' should be marked [[nodiscard]] [modernize-use-nodiscard]

Suggested change

bool shouldVisitImplicitCode() const { return true; }

[[nodiscard]] bool shouldVisitImplicitCode() const { return true; }

github-actions · 2024-12-12T17:14:23Z

lib/Differentiator/DiffPlanner.cpp

+        : m_SemaRef(SemaRef), m_BeginLoc(beginLoc) {}
+
+    // Required for visiting lambda declarations.
+    bool shouldVisitImplicitCode() const { return true; }


warning: method 'shouldVisitImplicitCode' can be made static [readability-convert-member-functions-to-static]

Suggested change

bool shouldVisitImplicitCode() const { return true; }

static bool shouldVisitImplicitCode() { return true; }

github-actions · 2024-12-12T17:14:23Z

lib/Differentiator/DiffPlanner.cpp

+    bool shouldVisitImplicitCode() const { return true; }
+
+    bool VisitDeclRefExpr(DeclRefExpr* DRE) {
+      if (auto* VD = dyn_cast<VarDecl>(DRE->getDecl())) {


warning: no header providing "clang::dyn_cast" is directly included [misc-include-cleaner]

lib/Differentiator/DiffPlanner.cpp:20:

+ #include <clang/Basic/LLVM.h>

github-actions · 2024-12-12T17:14:23Z

lib/Differentiator/DiffPlanner.cpp

        }
+      } else if (isa<FunctionDecl>(DRE->getDecl()))


warning: no header providing "clang::isa" is directly included [misc-include-cleaner]

} else if (isa<FunctionDecl>(DRE->getDecl())) ^

github-actions · 2024-12-12T17:14:24Z

lib/Differentiator/DiffPlanner.cpp

+    bool VisitCXXRecordDecl(CXXRecordDecl* RD) {
+      auto callOperatorDeclName =
+          m_SemaRef.getASTContext().DeclarationNames.getCXXOperatorName(
+              OverloadedOperatorKind::OO_Call);


warning: no header providing "clang::OverloadedOperatorKind" is directly included [misc-include-cleaner]

lib/Differentiator/DiffPlanner.cpp:20:

+ #include <clang/Basic/OperatorKinds.h>

github-actions · 2024-12-12T17:14:24Z

lib/Differentiator/DiffPlanner.cpp

+
+      // Emit error diagnostics
+      if (R.empty()) {
+        const char diagFmt[] = "'%0' has no defined operator()";


warning: do not declare C-style arrays, use std::array<> instead [cppcoreguidelines-avoid-c-arrays]

const char diagFmt[] = "'%0' has no defined operator()"; ^

github-actions · 2024-12-12T17:14:24Z

lib/Differentiator/DiffPlanner.cpp

+            DiagnosticsEngine::Level::Error, diagFmt);
+        m_SemaRef.Diag(m_BeginLoc, diagId) << RD->getName();
+      } else if (!R.isSingleResult()) {
+        const char diagFmt[] =


warning: do not declare C-style arrays, use std::array<> instead [cppcoreguidelines-avoid-c-arrays]

const char diagFmt[] = ^

github-actions · 2024-12-12T17:14:24Z

lib/Differentiator/DiffPlanner.cpp

+        // Emit diagnostics for candidate functions
+        for (auto oper = R.begin(), operEnd = R.end(); oper != operEnd;
+             ++oper) {
+          auto* candidateFn = cast<CXXMethodDecl>(oper.getDecl());


warning: no header providing "clang::cast" is directly included [misc-include-cleaner]

auto* candidateFn = cast<CXXMethodDecl>(oper.getDecl()); ^

github-actions

clang-tidy made some suggestions

github-actions · 2024-12-13T21:03:30Z

lib/Differentiator/DiffPlanner.cpp

+        }
+      } else if (R.isSingleResult() == 1 &&
+                 cast<CXXMethodDecl>(R.getFoundDecl())->getAccess() !=
+                     AccessSpecifier::AS_public) {


warning: no header providing "clang::AccessSpecifier" is directly included [misc-include-cleaner]

lib/Differentiator/DiffPlanner.cpp:20:

+ #include <clang/Basic/Specifiers.h>

github-actions · 2024-12-13T21:03:30Z

lib/Differentiator/DiffPlanner.cpp

+      } else if (R.isSingleResult() == 1 &&
+                 cast<CXXMethodDecl>(R.getFoundDecl())->getAccess() !=
+                     AccessSpecifier::AS_public) {
+        const char diagFmt[] =


warning: do not declare C-style arrays, use std::array<> instead [cppcoreguidelines-avoid-c-arrays]

const char diagFmt[] = ^

github-actions · 2024-12-13T21:03:30Z

lib/Differentiator/DiffPlanner.cpp

+        for (auto* decl : RD->decls()) {
+          if (decl == callOperator)
+            break;
+          if (isa<AccessSpecDecl>(decl)) {


warning: no header providing "clang::AccessSpecDecl" is directly included [misc-include-cleaner]

lib/Differentiator/DiffPlanner.cpp:20:

+ #include <clang/AST/DeclCXX.h>

github-actions · 2024-12-13T21:03:30Z

lib/Differentiator/DiffPlanner.cpp

-    return finder.m_FnDRE;
-  }
+        // Emit diagnostics for the found call operator
+        m_SemaRef.Diag(callOperator->getBeginLoc(), diag::note_access_natural)


warning: no header providing "clang::diag::note_access_natural" is directly included [misc-include-cleaner]

lib/Differentiator/DiffPlanner.cpp:20:

+ #include <clang/Basic/DiagnosticSema.h>

github-actions · 2024-12-13T21:03:30Z

lib/Differentiator/DiffPlanner.cpp

+            << isImplicit;
+
+      } else {
+        assert(R.isSingleResult() &&


warning: no header providing "assert" is directly included [misc-include-cleaner]

lib/Differentiator/DiffPlanner.cpp:20:

+ #include <cassert>

github-actions · 2024-12-13T21:03:30Z

lib/Differentiator/DiffPlanner.cpp

@@ -237,7 +225,7 @@
      // Add the "&" operator
      auto* newUnOp =
          SemaRef
-              .BuildUnaryOp(nullptr, noLoc, UnaryOperatorKind::UO_AddrOf, DRE)
+              .BuildUnaryOp(nullptr, noloc, UnaryOperatorKind::UO_AddrOf, DRE)


warning: no header providing "clang::UnaryOperatorKind" is directly included [misc-include-cleaner]

lib/Differentiator/DiffPlanner.cpp:20:

+ #include <clang/AST/OperationKinds.h>

github-actions

clang-tidy made some suggestions

github-actions · 2024-12-13T21:27:56Z

include/clad/Differentiator/DiffPlanner.h

+  std::set<const clang::VarDecl*> getVariedDecls() const {
+    return this->m_ActivityRunInfo.VariedDecls;
+  }
+  DiffRequest() {}


warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]

Suggested change

DiffRequest() {}

DiffRequest() = default;

github-actions · 2024-12-13T21:27:56Z

lib/Differentiator/DiffPlanner.cpp

-                              m_ActivityRunInfo.ToBeRecorded.end()));
-
+      if (Builder)
+        for (auto diffreq : this->Builder->m_DiffRequestGraph.getNodes())


warning: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy]

Suggested change

for (auto diffreq : this->Builder->m_DiffRequestGraph.getNodes())

for (const auto& diffreq : this->Builder->m_DiffRequestGraph.getNodes())

github-actions · 2024-12-13T21:27:56Z

lib/Differentiator/DiffPlanner.cpp

-
+      if (Builder)
+        for (auto diffreq : this->Builder->m_DiffRequestGraph.getNodes())
+          for (auto vd : diffreq.getVariedDecls())


warning: 'auto vd' can be declared as 'const auto *vd' [llvm-qualified-auto]

Suggested change

for (auto vd : diffreq.getVariedDecls())

for (const auto *vd : diffreq.getVariedDecls())

ovdiiuv force-pushed the varfix branch from 0f81a9c to 7b6e3b8 Compare November 21, 2024 15:53

github-actions bot reviewed Nov 21, 2024

View reviewed changes

ovdiiuv force-pushed the varfix branch 2 times, most recently from 7cb5d2b to d39b683 Compare November 21, 2024 17:51

ovdiiuv force-pushed the varfix branch 2 times, most recently from 63d431f to 3c1a59d Compare November 21, 2024 20:57

github-actions bot reviewed Nov 21, 2024

View reviewed changes

lib/Differentiator/ActivityAnalyzer.cpp Outdated Show resolved Hide resolved

ovdiiuv force-pushed the varfix branch from 3c1a59d to ef4ff13 Compare November 21, 2024 21:50

github-actions bot reviewed Nov 25, 2024

View reviewed changes

ovdiiuv force-pushed the varfix branch 2 times, most recently from 3d2263b to d63cb79 Compare November 25, 2024 20:17

Max Andriychuk added 4 commits December 12, 2024 16:53

Mark variables passed by pointer/reference as varied

fa80722

Add tests

96e9cef

Don't mark nonvaried constant params

f3eeeaf

Improve CallExpr analysis

fac1aee

ovdiiuv force-pushed the varfix branch from ead9af6 to e092f26 Compare December 12, 2024 15:55

github-actions bot reviewed Dec 12, 2024

View reviewed changes

ovdiiuv force-pushed the varfix branch from e092f26 to 8e1f3a2 Compare December 12, 2024 17:06

github-actions bot reviewed Dec 12, 2024

View reviewed changes

ovdiiuv force-pushed the varfix branch 2 times, most recently from d349c5a to d255a1f Compare December 13, 2024 20:54

github-actions bot reviewed Dec 13, 2024

View reviewed changes

ovdiiuv force-pushed the varfix branch from d81e803 to de5920d Compare December 13, 2024 21:20

github-actions bot reviewed Dec 13, 2024

View reviewed changes

ovdiiuv force-pushed the varfix branch from de5920d to 2506ad1 Compare December 14, 2024 15:07

Remove static set from DiffReq

7bf55f3

ovdiiuv force-pushed the varfix branch from 2506ad1 to 7bf55f3 Compare December 14, 2024 15:07

ovdiiuv requested a review from vgvassilev December 16, 2024 14:06

	bool shouldVisitImplicitCode() const { return true; }
	[[nodiscard]] bool shouldVisitImplicitCode() const { return true; }

	bool shouldVisitImplicitCode() const { return true; }
	static bool shouldVisitImplicitCode() { return true; }

	void setVariedDecls(std::set<const clang::VarDecl*> init) {
	void setVariedDecls(const std::set<const clang::VarDecl*>& init) {

	for (auto diffreq : this->Builder->m_DiffRequestGraph.getNodes())
	for (const auto& diffreq : this->Builder->m_DiffRequestGraph.getNodes())

	for (auto vd : diffreq.getVariedDecls())
	for (const auto *vd : diffreq.getVariedDecls())

Don't mark non-varied constant params #1148

Are you sure you want to change the base?

Don't mark non-varied constant params #1148

Conversation

ovdiiuv commented Nov 21, 2024

github-actions bot left a comment

Choose a reason for hiding this comment

codecov bot commented Nov 21, 2024 • edited Loading

Codecov Report

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Nov 25, 2024

Choose a reason for hiding this comment

github-actions bot Nov 25, 2024

Choose a reason for hiding this comment

github-actions bot Nov 25, 2024

Choose a reason for hiding this comment

github-actions bot Nov 25, 2024

Choose a reason for hiding this comment

github-actions bot Nov 25, 2024

Choose a reason for hiding this comment

github-actions bot Nov 25, 2024

Choose a reason for hiding this comment

github-actions bot Nov 25, 2024

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Nov 25, 2024

Choose a reason for hiding this comment

github-actions bot Nov 25, 2024

Choose a reason for hiding this comment

github-actions bot Nov 25, 2024

Choose a reason for hiding this comment

github-actions bot Nov 25, 2024

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Dec 12, 2024

Choose a reason for hiding this comment

github-actions bot Dec 12, 2024

Choose a reason for hiding this comment

github-actions bot Dec 12, 2024

Choose a reason for hiding this comment

github-actions bot Dec 12, 2024

Choose a reason for hiding this comment

github-actions bot Dec 12, 2024

Choose a reason for hiding this comment

github-actions bot Dec 12, 2024

Choose a reason for hiding this comment

github-actions bot Dec 12, 2024

Choose a reason for hiding this comment

github-actions bot Dec 12, 2024

Choose a reason for hiding this comment

github-actions bot Dec 12, 2024

Choose a reason for hiding this comment

github-actions bot Dec 12, 2024

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Dec 12, 2024

Choose a reason for hiding this comment

github-actions bot Dec 12, 2024

Choose a reason for hiding this comment

github-actions bot Dec 12, 2024

Choose a reason for hiding this comment

github-actions bot Dec 12, 2024

Choose a reason for hiding this comment

github-actions bot Dec 12, 2024

Choose a reason for hiding this comment

github-actions bot Dec 12, 2024

Choose a reason for hiding this comment

github-actions bot Dec 12, 2024

Choose a reason for hiding this comment

github-actions bot Dec 12, 2024

Choose a reason for hiding this comment

github-actions bot Dec 12, 2024

Choose a reason for hiding this comment

github-actions bot Dec 12, 2024

codecov bot commented Nov 21, 2024 •

edited

Loading